Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google AIP docs to CONTRIBUTING.md #2036

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Add Google AIP docs to CONTRIBUTING.md #2036

merged 1 commit into from
Mar 30, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

As came up in #1677, we want to use the Google AIP documentation as a recommended guide for building new API surfaces in Agones.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel
Add Google AIP docs to CONTRIBUTING.md
a145937 
As came up in googleforgames#1677, we want to use the Google AIP documentation as a
recommended guide for building new API surfaces in Agones.
@markmandel markmandel added kind/documentation Documentation for Agones area/meta Organisational matters. e.g. Governance, release cycles, etc. labels Mar 30, 2021
@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b4752ee1-1e47-4a9c-b8d3-fb6543f69b7b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2036/head:pr_2036 && git checkout pr_2036
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-a145937

@roberthbailey roberthbailey merged commit ba24da3 into googleforgames:main Mar 30, 2021
@markmandel markmandel deleted the meta/contrib-api branch March 30, 2021 23:19
@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. cla: yes kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @google-oss-robot @agones-bot @roberthbailey